Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 )
Change subject: bitbang-spi.c: support clock polarity and phase
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Patchset:
PS1:
Too much going on in one patch with no commit msg body explaining anything. I think on a quick inspection there is at least two patches here, one for adding the mode and the other where you combine RW primitives.
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49255/comment/07d5e9bf_d0880ff5
PS1, Line 78: bitbang_spi_xfer(
this is its own patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04c1dfe132d756119229b27c3cd611d1be1abc8d
Gerrit-Change-Number: 49255
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Xiang Wang
merle@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 09 Jan 2021 10:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment