Attention is currently required from: Miklós Márton, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84203?usp=email )
Change subject: Fix FEATURE_NO_ERASE chips and add test for them
......................................................................
Patch Set 6:
(1 comment)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/84203/comment/8a6060f0_9c7715a2?usp... :
PS5, Line 152: * Feature indicates that the chip does not require erase before writing.
: * For implementation details, see spi95.c and search for M95M02 definition in flashchips.c.
That's reasonable, but I think we can spend a few more words to include much of the explanation we'v […]
Thank you so much! I updated the comment
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84203?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I582fe00da0715e9b5e92fcc9d15d5a90a2615117
Gerrit-Change-Number: 84203
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Thu, 12 Sep 2024 05:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org