Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43602 )
Change subject: git-hooks: Add check-style for pre-commit hook ......................................................................
Patch Set 1: Code-Review-2
(4 comments)
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG@11 PS1, Line 11: Add check-style rule to Makefile It would need to be added to meson in this commit as well. I think long term we should drop the Makefile in favour of just meson however i'll leave that discussion to another commit.
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG@14 PS1, Line 14: - Import checkpatch.pl, along with certain dependencies (spelling.txt : and const_structs.checkpatch) and .checkpatch.conf. I am not so keen, -2 not so keen, on having coreboot's unreasonbly slow pre-commit hook stuff land here as well.
If spelling and that sort of thing should be checked then a build target that is run by the bot and a report generated is more reasonable imho.
Regardless, in it's current form it isn't fit for purpose here yet. Can we take it out and just land a working clang-format we can all agree on and have that done please?
https://review.coreboot.org/c/flashrom/+/43602/1//COMMIT_MSG@16 PS1, Line 16: Add .clang-format from CB:3 I am in favour of clang-format coming to Flashrom and it has been suggested a number of times now.
I don't recall precisely what Nico had to say but it was along the lines of Flashrom having sometimes longer lines than usual in some cases? Nico please correct me here.
In any case, I would be in favour of this part of the changeset and having it hooked up to the build bot as a target that is run as well as a pre-commit hook.
https://review.coreboot.org/c/flashrom/+/43602/1/util/lint/const_structs.che... File util/lint/const_structs.checkpatch:
https://review.coreboot.org/c/flashrom/+/43602/1/util/lint/const_structs.che... PS1, Line 1: cpi_dock_ops : address_space_operations : backlight_ops : block_device_operations : dentry_operations : dev_pm_ops : dma_map_ops : extent_io_ops : file_lock_operations : file_operations : hv_ops : ide_dma_ops : intel_dvo_dev_ops : item_operations : iwl_ops : kgdb_arch : kgdb_io : kset_uevent_ops : lock_manager_operations : microcode_ops : mtrr_ops : neigh_ops : nlmsvc_binding : of_device_id : pci_raw_ops : pipe_buf_operations : platform_hibernation_ops : platform_suspend_ops : proto_ops : rpc_pipe_ops : seq_operations : snd_ac97_build_ops : soc_pcmcia_socket_ops : stacktrace_ops : sysfs_ops : tty_operations : uart_ops : usb_mon_operations : wd_ops none of these have anything to do with flashrom