Attention is currently required from: Aarya, Alexander Goncharov, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78985?usp=email )
Change subject: tests: Add test cases for erasing/writing unaligned layout regions
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Added one more test case when logical layout does not cover the whole chip memory.
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/78985/comment/f9da4339_a73373ff :
PS1, Line 31: #define TEST_CASES_NUM 19
Any reason not to make this `(sizeof(test_cases) / sizeof(*test_cases))` instead? That way it doesn' […]
Actually yes, no reason. I think this was from the very first version of the test, maybe for creating array, and just stayed. I removed the macro.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/78985?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I726a30b0e47a966e8093ddc19abf4a65fb1d70ce
Gerrit-Change-Number: 78985
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Fri, 10 Nov 2023 10:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment