Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 )
Change subject: s25f.c: import from cros flashrom ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG@7 PS11, Line 7: import from cros flashrom still says "import". What about a commit short msg that actually says what this does?
`s25f.c: Implement probe and block erasure logic for Spansion`
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG@12 PS11, Line 12: Brings over basic support for s25f chips Can you please elaborate here with details. The following implements Spansion probe logic which is different because .. and block erasures for Spansion that do ..
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG@12 PS11, Line 12: but does not include : writeprotect support which will be added in a following patch. That is irrelevant here.
https://review.coreboot.org/c/flashrom/+/46140/11/chipdrivers.h File chipdrivers.h:
https://review.coreboot.org/c/flashrom/+/46140/11/chipdrivers.h@23 PS11, Line 23: /* unrelated change