Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34661 )
Change subject: Add support for STLINK V3 debugger/programmer via its SPI bridge
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/flashrom/+/34661/6/stlinkv3_spi.c
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/34661/6/stlinkv3_spi.c@84
PS6, Line 84: enum spi_nss {
What does 'NSS' mean? Please add a little comment, explaining the brevity.
NSS stands for Negated Slave Select. ST refers to the chip select pin in their docs (and in their API), so I have choosen to conforman with that. But yeah a bit comment never hurts.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icffab87ac8f2c570187ed753ec70f054541873a4
Gerrit-Change-Number: 34661
Gerrit-PatchSet: 7
Gerrit-Owner: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 22 Dec 2019 22:17:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Gerrit-MessageType: comment