22 Dec
2018
22 Dec
'18
5:03 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28804 )
Change subject: dediprog: Enable 4BA support for SF600, protocol V2 ......................................................................
Patch Set 2:
Did you test the native instructions only? e.g. you could remove the native flags / erase functions (and in another step the enter 4BA flags) for your chip to test different paths.
I think so... I tried with only FEATURE_4BA_NATIVE enabled and I also tried with only FEATURE_4BA enabled, the former should have used native instructions only, right?
Alas, FEATURE_4BA includes _NATIVE and the latter is automatically selected if available. So it's likely you tested native instructions twice.
--
To view, visit https://review.coreboot.org/c/flashrom/+/28804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841
Gerrit-Change-Number: 28804
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Sat, 22 Dec 2018 17:03:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment