16 Oct
2019
16 Oct
'19
3:37 p.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35831 )
Change subject: flashrom: Add support for ARC platform ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35831/2/platform.h File platform.h:
https://review.coreboot.org/c/flashrom/+/35831/2/platform.h@130 PS2, Line 130: __arceb__
Looking at gcc [1] more closely, it seems __BIG_ENDIAN__ and __LITTLE_ENDIAN__ are defined along wit […]
The author seems to agree with this approach, and has updated the PR: https://github.com/flashrom/flashrom/pull/88
LMK what you think and if the change seems sensible I'll upload the updated version to gerrit.
--
To view, visit https://review.coreboot.org/c/flashrom/+/35831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I88cbe74b716d5fab16133fbf2ce9c35b74c25f32
Gerrit-Change-Number: 35831
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 15:37:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks david.hendricks@gmail.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment