14 May
2023
14 May
'23
9:25 a.m.
Attention is currently required from: Miklós Márton, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74963 )
Change subject: ni845x_spi: support building with Meson ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Miklos, what do you think about it? Thanks!
ni845x is neither compiling with make nor with meson. Also when fixing the compilation bugs, the linking is not working.
--
To view, visit https://review.coreboot.org/c/flashrom/+/74963
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I90e85c424f97898b47bf0a3d78672d6c25af12b0
Gerrit-Change-Number: 74963
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov chat@joursoir.net
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Sun, 14 May 2023 09:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment