Attention is currently required from: Stefan Reinauer, Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75194 )
Change subject: layout.c: Mitigate untrusted FMAP's within fw images address root ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/75194/comment/84873ffd_a98aebd3 PS1, Line 14: parsing untrusted data with a privilaged process But what is considered privileged? For a regular user running flashrom, relative paths can already do a lot of damage.
https://review.coreboot.org/c/flashrom/+/75194/comment/3064add2_f8aa47cc PS1, Line 15: unless you require : the internal programmer in which case the internal image is : implicitly trusted. Unless you have something like vboot (or similar) which treats A/B partitions as untrusted.
https://review.coreboot.org/c/flashrom/+/75194/comment/9a474bf2_2edae7cc PS1, Line 21: Feel free to add a Found-by: line.
File layout.c:
https://review.coreboot.org/c/flashrom/+/75194/comment/0bdbcf66_447b2a8a PS1, Line 199: filename[0] == '\' If this is meant to secure DOS/Windows paths, you'd also have to check for "[a-zA-Z]:", I suppose.