Attention is currently required from: Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61362 )
Change subject: util/ich_descriptors_tool: Invert the meaning of 'dual_output' bit ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61362/comment/15303ce1_a9734f79 PS1, Line 7: util/ich_descriptors_tool nit: I'd use `ich_descriptors.c` as file path, the code is also used by flashrom itself.
https://review.coreboot.org/c/flashrom/+/61362/comment/82c4ced2_4120f43a PS1, Line 11: According to the SPI Programming Guide the dual output is : enabled when this bit is set and disabled if not (checked for Panther : Point, Lewisburg C620, Apollo Lake and Elkhart Lake). Starting with "According to the SPI Programming Guide" makes it seem like you only checked one SPI programming guide. I'd suggest rephrasing the sentence as follows:
According to the SPI Programming Guides for Panther Point, Lewisburg C620, Apollo Lake and Elkhart Lake, the dual output is enabled when this bit is set and disabled if not.
Another option would be to move the part in parentheses closer to "SPI Programming Guide":
According to various SPI Programming Guides (checked for Panther Point, Lewisburg C620, Apollo Lake and Elkhart Lake), the dual output is enabled when this bit is set and disabled if not.
Patchset:
PS1: I checked the SPI programming guides for Lynx Point, Wildcat Point, Bay Trail, Skylake-H and Gemini Lake; all agree with this change.