[flashrom-gerrit] [S] Change in flashrom[master]: layout.c: Use calloc() to ensure a zeroed layout

[Felix Singer (Code Review)]

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68279 )

Change subject: layout.c: Use calloc() to ensure a zeroed layout
......................................................................

layout.c: Use calloc() to ensure a zeroed layout

No need to malloc() and then do a DIY memset to zero of the
heap. Just use calloc(1, ..) to get a zeroed heap.

Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68279
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Felix Singer 
---
M layout.c
1 file changed, 18 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/layout.c b/layout.c
index 0212699..be88428 100644
--- a/layout.c
+++ b/layout.c
@@ -355,14 +355,12 @@

int flashrom_layout_new(struct flashrom_layout **const layout)
 {
-	*layout = malloc(sizeof(**layout));
+	*layout = calloc(1, sizeof(**layout));
    if (!*layout) {
    	msg_gerr("Error creating layout: %s\n", strerror(errno));
    	return 1;
    }

-	const struct flashrom_layout tmp = { 0 };
-	**layout = tmp;
    return 0;
 }