Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/83673?usp=email )
Change subject: Remove the Makefile ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: I tried git grep -n 'Makefile' and found some stuff which is not covered in this patch:
Doxyfile:1199:# Makefile in the HTML output directory. Running make will produce the docset in Doxyfile:1611:# bitmaps for formulas in the HTML output, but not in the Makefile that is Doxyfile:1948:# Makefile rules, Perl scripts and LaTeX code to be able to generate PDF and DVI Doxyfile:1967:# so different doxyrules.make files included by the same Makefile don't
util/manibuilder/Makefile:3:include Makefile.targets util/manibuilder/Makefile:15:include Makefile.anita util/manibuilder/README.md:71: make: *** [Makefile:1075: libflashrom.o] Error 1
The manibuilder directory doesn't have a meson.build file yet :( I guess we need it. The tricky thing is, it's not built from root build file...
File doc/dev_guide/building_with_make.rst:
PS2: Should this be removed from index file of dev_guide directory? I would expect sphinx to complain when building (or a warning at least) if index references non-existing file, did it complain?
File doc/release_notes/v_1_5-devel.rst:
https://review.coreboot.org/c/flashrom/+/83673/comment/23c94a9e_cb460dda?usp... : PS2, Line 2: v1.5-devel I was thinking to have a generic name to this file, for example next_release.rst, "Next release", or something else without dates or version numbers. This way the name of the doc and url on the website stays the same, and at any time anyone can open "Next release" document and it always be exactly it: what is coming next.
https://review.coreboot.org/c/flashrom/+/83673/comment/0d8bdbe1_e80efc9a?usp... : PS2, Line 4: : This document describes the major changes to flashrom since the release : of version 1.4. These changes will be included in the future v1.5 release. In the same spirit, I would make the intro generic, so that we need to compose it once and it stays forever relevant.
This document describes the major changes that are expected to be included in the next release of flashrom. The work described below is currently available at HEAD only (see doc "building from source"), and keep in mind the changes are not yet released and might receive further bugfixes and improvements.
Something like that :)