21 Jan
2020
21 Jan
'20
11:32 a.m.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38488 )
Change subject: Automatic programmer driver writer ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh File build_new_driver.sh:
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh@1 PS1, Line 1: #!/bin/bash '/usr/bin/env bash' is preferred.
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh@42 PS1, Line 42: What are your thoughts on putting the lines below in a separate file (build_new_driver.sh.inc)?
--
To view, visit https://review.coreboot.org/c/flashrom/+/38488
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd000001
Gerrit-Change-Number: 38488
Gerrit-PatchSet: 1
Gerrit-Owner: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-Comment-Date: Tue, 21 Jan 2020 11:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment