8 Apr
2020
8 Apr
'20
9:27 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34595 )
Change subject: flashchips: Add W25Q512JV ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15912 PS1, Line 15912: .tested = TEST_OK_PREW,
I don't understand, can you explain what you mean?
Erase was definitely not working with PS1, so I doubted that it was tested at all. PS2 looks good.
--
To view, visit https://review.coreboot.org/c/flashrom/+/34595
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8d16f0918785795cc49500435a03641b87d706e9
Gerrit-Change-Number: 34595
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Stanley
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Philippe Mathieu-Daudé f4bug@amsat.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Apr 2020 21:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Stanley
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment