Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email )
Change subject: rpmc: add rpmc commands feature ......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS4:
Matti, thank you so much for your patience! I made another round of comments, but probably the last […]
As I don't currently own a second non spi cabable chip, that can also work as a SFDP-capable chip, I used the dummy programmer with `dummy:emulate=MX25L6436` which can then be handled as a "SFDP-capable chip". At least for read write and verify all operations work as expected.
Read write and verify also still work when using the W25R chip through the ft2232_spi programmer. Also while other rpmc operations are ran in the same call.
File rpmc.c:
https://review.coreboot.org/c/flashrom/+/84934/comment/ac584c2e_e11b40f4?usp... : PS4, Line 117: usleep(flash->chip->rpmc_ctx.polling_long_delay_write_counter_us)
`programmer_delay` seems like the right choice here, since we have a flashctx.
Done