Attention is currently required from: Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55495 )
Change subject: programmer.h: sort programmer entries alphabetically
......................................................................
Patch Set 2:
(1 comment)
File programmer.h:
https://review.coreboot.org/c/flashrom/+/55495/comment/1302b184_55466068
PS1, Line 86: extern const struct programmer_entry programmer_nicintel;
doesn't `nicintel` come before `nicintel_eeprom`?
right, I've used the sort function from the IDE and it sorts with the ';' included
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5
Gerrit-Change-Number: 55495
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 14 Jun 2021 12:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment