Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 )
Change subject: Makefile: Make pkg-config mandatory to find libpci ......................................................................
Patch Set 12: Code-Review+1
(2 comments)
Patchset:
PS12: I'm not 100% sure it's a move into the right direction. If we want reliable build results at some point, i.e. don't disable programmers automatically, we'd have to bring back some of the dropped functionality later. For instance, listing the (enabled) programmers that require libpci. Would it be hard to maintain this at the moment?
File Makefile:
https://review.coreboot.org/c/flashrom/+/59050/comment/0f77180f_9fb798c8 PS7, Line 772: # This is a dirty hack, but it saves us from checking all PCI drivers and all platforms manually. : # libpci may need raw memory, MSR or PCI port I/O on some platforms. : # Individual drivers might have the same needs as well. Doesn't this comment stay valid? I guess we should at some point untangle our use of `physmap.c`/`hwaccess.c` from libpci dependencies. i.e. if libpci needs something, it would be to link with another library, but libpci would never need anything in our code (`physmap.c` etc.), right?