29 Apr
2020
29 Apr
'20
1:53 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39973 )
Change subject: libflashrom.c: Use correct type for sizeof ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/39973/3/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/39973/3/libflashrom.c@185 PS3, Line 185: struct flashrom_board_info I would write `*supported_boards` here. It's harder to break.
--
To view, visit https://review.coreboot.org/c/flashrom/+/39973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I66e875d54c9a7cc59898b072b052282b0b5cbb2f
Gerrit-Change-Number: 39973
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Apr 2020 13:53:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment