Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33997 )
Change subject: flashchips.h: merge definitions from Chromium fork ......................................................................
Patch Set 6:
Patch Set 6: Code-Review+1
(7 comments)
Looks good, save for a few nits
Hi Angel, Nico,
After thinking about this, probably the right action is to drop this patch, then update this flashchips.h a piece at a time as we bring definitions upstream from Chromium.
I had been hoping to have identical flashchips.h files in both upstream and downstream, but (a) it requires more thought than I've put into it so far, and (b) having unused definitions in flashchips.h is confusing and unhelpful, particularly here in upstream.
Thanks,
Alan.