David Hendricks has posted comments on this change. ( https://review.coreboot.org/19528 )
Change subject: Initial MX25L25635F support ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/19528/1/flashchips.c File flashchips.c:
PS1, Line 8069: .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_20_4ba, : }, { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = spi_block_erase_52_4ba, : }, { : .eraseblocks = { {64 * 1024, 512} }, : .block_erase = spi_block_erase_d8_4ba, I ran into an interesting problem with the MX25L25635F when flashing via Dediprog SF600 - Somehow the 4BYTE bit kept getting cleared after an erase operation, so I had to change these to use the *_direct erase functions.
I seem to recall this chip working fine on my RaspPi programmer using this patch set, so maybe what I encountered was a quirk with the SF600.
Anyway, just thought I would mention it in case you ran into similar issues. We can change to *_direct later on if it seems necessary, or add some hack to Dediprog code if the issue I saw seems specific to the programmer.