Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro ......................................................................
Patch Set 5:
(4 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/64d0162f_e7eff9d0 PS5, Line 141: 2 bits Can you elaborate more than just saying 2 bits so to help the reader who may not have access to the datasheet?
https://review.coreboot.org/c/flashrom/+/62891/comment/572201ee_9b2dfb24 PS5, Line 143: 1-2: FLASH Cycle `1-n: FLASH Cycle`
https://review.coreboot.org/c/flashrom/+/62891/comment/38fed04e_6752ca59 PS5, Line 145: #define HSFC_FCYCLE (0x3 << HSFC_FCYCLE_OFF) isn't this removable now since you would have `HSFC_FCYCLE_MASK(HSFC_FCYCLE_BIT_WIDTH_ICH9)`
https://review.coreboot.org/c/flashrom/+/62891/comment/52909fa7_67612bb7 PS5, Line 506: _p unrelated pp change to this patch.