Attention is currently required from: Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67479 )
Change subject: spi: Make 'default_spi_write_aai' the default unless defined ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67479/comment/5617b5f3_434b5056 PS1, Line 9: Drop the explicit need to specify the default 'default_spi_write_aai' Please mention the struct where you perform the changes on
Patchset:
PS1: Two things: First, from the commit message I can't get the conclusion that, from this patch on, the control flow code looks up if there is a custom function for the programmer and if not uses the default one.
Second, as I mentioned already in the email, IMO it would be god to combine this with a rename to make it clear that the functions are optional and there is an implicit default behavior.