11 Jun
2021
11 Jun
'21
2:24 p.m.
Attention is currently required from: Xiang W, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 )
Change subject: bitbang_spi.c: fix spi sequence in time and rename ......................................................................
Patch Set 16: Code-Review+2
(1 comment)
Patchset:
PS13:
This is a timing issue, and the signal changes sent should be earlier than received. […]
Can you add a TEST=`..` line in the commit message please?
--
To view, visit https://review.coreboot.org/c/flashrom/+/49264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1
Gerrit-Change-Number: 49264
Gerrit-PatchSet: 16
Gerrit-Owner: Xiang W wxjstz@126.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Shawn C citypw@hardenedlinux.org
Gerrit-Attention: Xiang W wxjstz@126.com
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 11 Jun 2021 14:24:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Xiang W wxjstz@126.com
Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-MessageType: comment