11 Jan
2021
11 Jan
'21
3:51 a.m.
Attention is currently required from: Edward O'Callaghan. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47908 )
Change subject: Makefile: Explicitly set '-std=c99' ......................................................................
Patch Set 3:
(2 comments)
File dmi.c:
https://review.coreboot.org/c/flashrom/+/47908/comment/3d245bf8_af41d1a8 PS3, Line 23: #define _GNU_SOURCE is there a downside to setting this explicitly in the build system?
https://review.coreboot.org/c/flashrom/+/47908/comment/27b96681_cc3d1a08 PS3, Line 26: #define _POSIX_C_SOURCE 200809L isn't this set explicitly now?
--
To view, visit https://review.coreboot.org/c/flashrom/+/47908
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4f973927fc018510a3beaa6c4fa2f356c77c7a6e
Gerrit-Change-Number: 47908
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Mon, 11 Jan 2021 02:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment