Attention is currently required from: Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70127 )
Change subject: ichspi: Expose flash descriptor regions through get_region()
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/70127/comment/2fa4e7b3_5eaadda4
PS2, Line 1830:
:
: #define EMBEDDED_CONTROLLER_REGION 8
:
: static enum ich_access_protection ec_region_rwperms(unsigned int i)
: {
I'll probably factor out of this patch. I'm not sure if we need this at all actually.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/70127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I019f3f407f6a2a82f686a168457e0e32961ff483
Gerrit-Change-Number: 70127
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Wed, 30 Nov 2022 05:11:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment