Attention is currently required from: Angel Pons, qianfan.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70529 )
Change subject: Add initial CH347T SPI programmer
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
PS3:
Done
What I meant by this is that the commit message should give some useful information about the patch, such as the things I suggested above in this comment thread. See the commit message in my original patch (CB:70573) for an example of what I mean.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/70529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6da5e308af76693e60308c8165349128e517e09a
Gerrit-Change-Number: 70529
Gerrit-PatchSet: 7
Gerrit-Owner: qianfan
qianfanguijin@163.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: qianfan
qianfanguijin@163.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Thu, 22 Dec 2022 07:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: qianfan
qianfanguijin@163.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment