27 Nov
2022
27 Nov
'22
3:57 p.m.
Attention is currently required from: Felix Singer, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70003 )
Change subject: cli, manpage: Clean up occurrences of old image argument ......................................................................
Patch Set 3:
(2 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/70003/comment/5e636031_8fd240f2 PS1, Line 621: include
Oh no... did I just do the blasphemy of changing the public API! how could I... %( […]
Done
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/70003/comment/8c68c31e_beb280ae PS2, Line 622: {"image", 1, NULL, 'i'},
Add a comment here that this is deprecated
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/70003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If457e2b8548034868105b515125d7e8b4d5f6134
Gerrit-Change-Number: 70003
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Sun, 27 Nov 2022 23:57:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment