Attention is currently required from: Xiang Wang, Paul Menzel, Angel Pons.
Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49637 )
Change subject: ft2232_spi.c: Generalize GPIOL pin control
......................................................................
Patch Set 9:
(2 comments)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49637/comment/54e9a4a5_88f36635
PS8, Line 396: "Valid values are 4 character strings of H, L, Z "
: "and X.\n"
Please don't break user-visible strings. They can be as long as necessary.
Done
https://review.coreboot.org/c/flashrom/+/49637/comment/aabcff97_43961e49
PS8, Line 402: "Example: gpiol=LZXH drives GPIOL 0 low, and GPIOL 3 "
: "high, sets GPIOL 1\n"
: "to an input and leaves GPIOL 2 in the default "
: "state\n", arg);
Ditto
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1f2b3b968577e62e3c5b11bcdf4afe2de6eb84ab
Gerrit-Change-Number: 49637
Gerrit-PatchSet: 9
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Xiang Wang
merle@hardenedlinux.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 21 Jan 2021 01:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment