Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection
......................................................................
Patch Set 15:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63724/comment/2cfeb50d_64b84875
PS11, Line 10: has some known and unknown bugs.
Speaking about bugs, and especially unknown bugs, can we collectively try detect them? Is this patch […]
Yes, everything should work as expected. The tests are currently a problem when not selecting all programmers.
File meson.build:
https://review.coreboot.org/c/flashrom/+/63724/comment/32e2bf9d_878b5f8c
PS2, Line 464: if host_machine.system() in systems_serial_support
For now the serial support is build as part of the programmer. […]
Done
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/63724/comment/dbd57eef_925b6a7e
PS7, Line 6: choices
yes, the choices ensure at least one programmer is enabled, there can't be a string which is no prog […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1
Gerrit-Change-Number: 63724
Gerrit-PatchSet: 15
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 21:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment
