31 Jul
2019
31 Jul
'19
8:30 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 )
Change subject: Fix -Wunused-parameter issues ......................................................................
Patch Set 5:
The idea here is to enable -Wextra eventually. The alternative obviously is to keep -Wunused-parameter disabled.
Does anyone have a preference?
--
To view, visit https://review.coreboot.org/c/flashrom/+/30410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Richard Hughes richard@hughsie.com
Gerrit-Reviewer: Stefan T stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 31 Jul 2019 08:30:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment