[flashrom-gerrit] Change in flashrom[master]: flashchips: Add support for Boya Microelectronics BY25Q128AS

[Jack Olsen (Code Review)]

Jack Olsen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44308 )

Change subject: flashchips: Add support for Boya Microelectronics BY25Q128AS
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/flashrom/+/44308/4/flashchips.c 
File flashchips.c:

https://review.coreboot.org/c/flashrom/+/44308/4/flashchips.c@3477 
PS4, Line 3477: spi_disable_blockprotect_at25fs040
> Just to be sure, how have you tested this? I haven't messed with flash chip block protection much (a […]

Yes. I initially had used spi_disable_blockprotect, but was told on GitHub at25fs040 was more appropriate, so I changed it, did another dump, worked just fine.