Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Sergii Dmytruk. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 18:
(1 comment)
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/6a885223_e2aecc46 PS14, Line 90: wait_for_ext_crystal
When the bit is 0, then it DOESN'T wait for external crystal.
No, it's exactly the other way round. Comment and var name are in conflict.
From the ITE source: "When this bit is set, the internal clock would act as a temporary clock to enable EC to configure some GPIO."
1 == "use internal clock until external crystal is ready" == "do NOT wait for the external crystal but temporarily use the internal UNTIL the external is ready"
in pseudocode:
``` clock = int while true: .... if ext_crystal_ready: clock = int break
.... ```
and
0 == "wait_for_ext_crystal" == "wait for the external crystal to be ready" iow. the chip does sth like this:
``` while !ext_crystal_ready: nop
... ```
That means the name `wait_for_ext_crystal` must be inverted to
`no_wait_for_ext_crystal` or `int_osc_until_crystal_ready`