Attention is currently required from: David Bartley, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54968 )
Change subject: flashchips: add support for Winbond W25Q01JV ......................................................................
Patch Set 4:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/54968/comment/2256e774_461975ec PS1, Line 17757: /* Full chip erase is fastest, typically takes 200s */
Well, maybe there is one low-hanging fruit: For the erase commandline option (-E), we could iterate over the list in reverse order?
Sounds like a very good idea. Do we have to account for region erases, though?
Yeah, seemed too easy. You are right, IIRC, we allow not block aligned regions, so this optimization would apply to a `-E` for the full flash only. (Otherwise, flashrom would see the flash-erase op, realize that it needs to back up every- thing outside the region, erase, and restore the backup.)