Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: spi: add support for Winbond W25Q64JW
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/40275/3/flashchips.c
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/40275/3/flashchips.c@17133
PS3, Line 17133: ZPIM
I think you can't tell if this is ZPIM or SSIG from model id; so maybe just leave it as W25Q64JW?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott.chao@bitland.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-CC: Paul Ma
magf@bitland.com.cn
Gerrit-Comment-Date: Thu, 09 Apr 2020 04:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment