Attention is currently required from: Anastasia Klimchuk, Richard Hughes.
Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: libflashrom: Update the API for progress callback
......................................................................
Patch Set 12:
(1 comment)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/fcc8ddc4_5ee85bc8?usp... :
PS12, Line 110: * Note: callback set with this function takes priority over the deprecated one which
: * could be set by deprecated function flashrom_set_progress_callback.
I think this note is no longer true because at most one callback can be set now.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/86031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a
Gerrit-Change-Number: 86031
Gerrit-PatchSet: 12
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 04 Mar 2025 15:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No