Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34661 )
Change subject: Add support for STLINK V3 debugger/programmer via its SPI bridge ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/flashrom/+/34661/7/stlinkv3_spi.c File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/34661/7/stlinkv3_spi.c@130 PS7, Line 130: sizeof(command) I guess this should be `command_length` now.
https://review.coreboot.org/c/flashrom/+/34661/7/stlinkv3_spi.c@140 PS7, Line 140: sizeof(answer) and `answer_length` here
https://review.coreboot.org/c/flashrom/+/34661/7/stlinkv3_spi.c@442 PS7, Line 442: return -1; This looked actually better before: print an error message, but continue to clean up (don't return early).