Attention is currently required from: ra1nb0w.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69678?usp=email )
Change subject: flashchips: Add Macronix MX25R1635F ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69678/comment/c891ae65_3672a846 : PS1, Line 13: Tested Can you mention which operation you tested, did you run verify at the end? (for example, from the chip definition it seems you ran probe/read/erase/write?)
Patchset:
PS1: Davide, I am so sorry that your patch got missed :\ I hope you are still here! Do you have a link to datasheets?
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/69678/comment/55704117_1f7f9fe6 : PS1, Line 9306: .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit 6 is quad enable */ : .unlock = spi_disable_blockprotect_bp3_srwd, These two are now enums are well (not function pointers anymore). If you rebase on the latest head you will see it does not compile anymore, because you need enum value here.