Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33828 )
Change subject: flashchips.c: Make whitespace consistent
......................................................................
Patch Set 6:
I agree to the changes. Though, if you want to keep
tool compatibility, you have to make this whitespace
style a rule. Otherwise the file may degrade again.
Such a rule would be best implemented as a pre-commit
check, I guess.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib2193798cc52641d6c443f8851903c749b31cb74
Gerrit-Change-Number: 33828
Gerrit-PatchSet: 6
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 09:45:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment