Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt
......................................................................
Patch Set 6:
(1 comment)
Please also update the manpage.
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@618
PS1, Line 618: msg_ginfo("vendor"%s" name="%s"\n",
Am I mistaken to think info is always printed and so it is good to channel everything though it? I h […]
Info is always printed, yes. Currently! If one ever wanted to change
that, should they search the whole code base for such cases? I have
to admit, one would actually only have to search UI code, but still,
we can avoid that.
I'm not even sure if we should ever use our msg*() functions in this
file.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56
Gerrit-Change-Number: 35591
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 09:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment