Attention is currently required from: Angel Pons.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error
......................................................................
Patch Set 6:
(2 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/9b813e46_e40d3a6d
PS3, Line 507: {
Please put this brace on the previous line
Done
https://review.coreboot.org/c/flashrom/+/62764/comment/040e55ee_2af139eb
PS3, Line 508: >=
nit: Please add spaces around `>=`
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39
Gerrit-Change-Number: 62764
Gerrit-PatchSet: 6
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 14 Mar 2022 10:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment