Attention is currently required from: Thomas Heijligen, Angel Pons, qianfan, Anastasia Klimchuk.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70573 )
Change subject: ch347_spi.c: Add initial support for the WCH CH347 ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I had already pushed a PR: https://review.coreboot. […]
Ah, I guess I should have checked Gerrit before I pushed my patch. Sorry about that. Large parts of our code does seem to be similar, although there are a few differences in featyres. Perhaps it would be easiest for one of us to push the unique parts as a new patch on top of the other's patch. Since you pushed your's first I'll see if I can push my changes on top of your code.
Also, may I ask where you found that info about the SPI config structure? The stuff I had found was just through fuzzing the vendor library with different inputs and observing the results, but your code has many more details than what the vendor library API exposes.