Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45431 )
Change subject: tests: Clear ID cache before trying to fetch chip ID a second time
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/45431/1/tests/spi25.c
File tests/spi25.c:
https://review.coreboot.org/c/flashrom/+/45431/1/tests/spi25.c@132
PS1, Line 132: clear_spi_id_cache();
perhaps? This is the only place where it's _needed_ though, so that's where I stopped. […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/45431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba6a56774ce5b51e0f7072b4600a9479cdabf8c7
Gerrit-Change-Number: 45431
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 09:40:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment