20 Aug
2018
20 Aug
'18
7:16 p.m.
Marc Schink has posted comments on this change. ( https://review.coreboot.org/28087 )
Change subject: Add initial J-Link SPI programmer ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/28087/2/jlink_spi.c File jlink_spi.c:
https://review.coreboot.org/#/c/28087/2/jlink_spi.c@344 PS2, Line 344:
Isn't this `dev` (as part of `devs`) free'd yet?
No, the device instance is not free'd because we still have a reference on it (jaylink_open())
--
To view, visit https://review.coreboot.org/28087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e
Gerrit-Change-Number: 28087
Gerrit-PatchSet: 4
Gerrit-Owner: Marc Schink flashrom-dev@marcschink.de
Gerrit-Reviewer: Marc Schink flashrom-dev@marcschink.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 20 Aug 2018 19:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No