Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26947 )
Change subject: bitbang_spi: Add half-duplex optimizations
......................................................................
Patch Set 2: Code-Review+1
Not sure if the full-duplex mode is used anywhere with SPI flash. If yes, that (slower) function should probably remain somewhere, but OTOH we don't need dead code either.
Nico?
--
To view, visit
https://review.coreboot.org/26947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b9f363716f651146c09113bda5fffe53b16738
Gerrit-Change-Number: 26947
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Thompson
daniel.thompson@linaro.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Jun 2018 09:58:03 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes