Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41646 )
Change subject: tests/: Add flashrom.c unit tests
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/41646/2/tests/flashrom.c
File tests/flashrom.c:
PS2:
Yes.
Right. Maybe we want to change this in the future, but IMHO it's good enough to start off with.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41646
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d9213f98c6c9639f2417466ba4895117e8d600a
Gerrit-Change-Number: 41646
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jun 2020 12:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment