6 Sep
2022
6 Sep
'22
9:16 a.m.
Attention is currently required from: Simon Buhrow, Nico Huber, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 )
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ......................................................................
Patch Set 25:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/9beacc47_7daf9821 PS24, Line 1088: for (i = 0; i < NUM_ERASEFUNCTIONS; i++) {
Yeah, changing the for-loop's condition like this won't work. The body […]
Yes, sorry, the main point should be the body where the indexed value is represented by a local variable.
--
To view, visit https://review.coreboot.org/c/flashrom/+/65879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4
Gerrit-Change-Number: 65879
Gerrit-PatchSet: 25
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 09:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Aarya aarya.chaumal@gmail.com
Gerrit-MessageType: comment