22 Mar
2022
22 Mar
'22
8:42 a.m.
Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62405 )
Change subject: board_enable.c: Port to use pcidev_find_vendorclass() helper ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: I want to have a deeper look into this before approving it. Unfortunately I'm on vacation at this time and haven't the resources to dig deeper in the code. Can you wait two weeks? Otherwise please find someone else for the review.
The first impression seams fine.
--
To view, visit https://review.coreboot.org/c/flashrom/+/62405
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d8e3dbd5eeb057d7c959a82678cca2345fc69d9
Gerrit-Change-Number: 62405
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 08:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment