Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47874 )
Change subject: lspcon_i2c_spi.c: Fix style
......................................................................
Patch Set 1:
Shiyu, I think we should follow the communities wisdom here until we can establish the issues of defaulting to C99. Can you try with checkpatch to determine the right course of action for this patch? I'll handle the C99 discussion piece and try to coordinate that back to you to keep us all aligned.
Thanks Nico and Angel for helping to coordinate the other side here. Hopefully we can figure out the blockers for C99 over C89 idioms on the ML.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4068ae7bdf6e053606cb063f7781dbb2d77792ff
Gerrit-Change-Number: 47874
Gerrit-PatchSet: 1
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 06:16:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment