Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30979 )
Change subject: [RFC] cli_classic: Add `--mode (read|write|verify|erase)` parameter
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Yeah, I remember that was a concern. […]
I just thought of something that may be confusing with the latest proposal:
# flashrom -r file # when no -i arg reads the whole chip
# flashrom -i region -r file # reads only region <region> on the ROM size file with everything else 0
# flashrom -r region:region_file file # is not obvious what file may have since no -i was provided
I think given the above it is much cleaner to keep the -i region:file interface.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/30979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idfba11ec9991aac423b07f68f7dc45e7bebbb06b
Gerrit-Change-Number: 30979
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Carl-Daniel Hailfinger
hailfinger@gmail.com
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan T
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 13 May 2021 01:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Daniel Campello
campello@chromium.org
Gerrit-MessageType: comment